-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: introduce sub Makefiles
#83
Conversation
ab56b40
to
b63b790
Compare
@@ -0,0 +1,24 @@ | |||
##@ Clients |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main Makefile
should only contain targets related to build
, install
and test
to keep it simple and easier to maintain.
Then where do we store other targets that may be useful? I suggest that we make use of sub Makefile
s such as scripts/clients.mk
and scripts/lint.mk
.
We can import the targets from these files into the main Makefile
using include scripts/clients.mk
. This is useful if you still want to show these targets in the main help.
It's also possible to call a target from a sub Makefile
without going through the main Makefile
, for example $ make -f scripts/clients.mk geth
.
@praetoriansentry wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it. I would just confirm that your changes don't impact any of the github work flows / ci.
avail
and geth
Makefile
s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
488d8d7
to
cfe1a43
Compare
PR rebased with latest changes. |
Related to @praetoriansentry's comment on #82
JIRA Ticket