Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: introduce sub Makefiles #83

Merged
merged 3 commits into from
Jul 6, 2023

Conversation

leovct
Copy link
Member

@leovct leovct commented Jun 22, 2023

Related to @praetoriansentry's comment on #82

JIRA Ticket

@leovct leovct force-pushed the leovct/chore-remove-geth-and-avail-targets branch from ab56b40 to b63b790 Compare July 3, 2023 10:15
@@ -0,0 +1,24 @@
##@ Clients
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main Makefile should only contain targets related to build, install and test to keep it simple and easier to maintain.

Then where do we store other targets that may be useful? I suggest that we make use of sub Makefiles such as scripts/clients.mk and scripts/lint.mk.

We can import the targets from these files into the main Makefile using include scripts/clients.mk. This is useful if you still want to show these targets in the main help.

It's also possible to call a target from a sub Makefile without going through the main Makefile, for example $ make -f scripts/clients.mk geth.

@praetoriansentry wdyt?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. I would just confirm that your changes don't impact any of the github work flows / ci.

@leovct leovct changed the title chore: remove targets related to avail and geth chore: introduce sub Makefiles Jul 3, 2023
@leovct leovct changed the title chore: introduce sub Makefiles chore: introduce sub Makefiles Jul 3, 2023
Copy link
Contributor

@praetoriansentry praetoriansentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@leovct leovct force-pushed the leovct/chore-remove-geth-and-avail-targets branch from 488d8d7 to cfe1a43 Compare July 6, 2023 15:20
@leovct
Copy link
Member Author

leovct commented Jul 6, 2023

PR rebased with latest changes.

@leovct leovct merged commit 926efe5 into main Jul 6, 2023
@leovct leovct deleted the leovct/chore-remove-geth-and-avail-targets branch July 6, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants